Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix popGesture freezes the app #5863

Merged
merged 3 commits into from
Jan 21, 2020
Merged

Fix popGesture freezes the app #5863

merged 3 commits into from
Jan 21, 2020

Conversation

yogevbd
Copy link
Collaborator

@yogevbd yogevbd commented Jan 21, 2020 •
edited
Loading

Closes #5502

@yogevbd yogevbd changed the title Fix popGesture freeze the app Fix popGesture freezes the app Jan 21, 2020
guyca
guyca requested changes Jan 21, 2020
View reviewed changes
lib/ios/RNNStackPresenter.m Outdated Show resolved Hide resolved
@yogevbd yogevbd merged commit 37473f8 into master Jan 21, 2020
@yogevbd yogevbd deleted the fixPopGestureFreez branch January 21, 2020 14:14
vshkl pushed a commit to vshkl/react-native-navigation that referenced this pull request Feb 5, 2020
@yogevbd @vshkl
Fix popGesture freezes the app (wix#5863)
480093d 
* Fix popGesture freeze the app

* Move popGestureDelegate initialization to init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guyca guyca guyca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

popGesture: false causes bugs for using the pop gesture on children screens
2 participants
@yogevbd @guyca