Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On tab press event #5880

Merged
merged 4 commits into from
Jan 28, 2020
Merged

On tab press event #5880

merged 4 commits into from
Jan 28, 2020

Conversation

pontusab
Copy link
Contributor

With the patch from #5545 and the help from @N3TC4T I made this PR.

bottomTab: {
  selectTabOnPress?: boolean
}

Navigation.events().registerBottomTabPressedListener(({ tabIndex, componentId }) => {
// Trigger open modal etc
});

@pontusab pontusab mentioned this pull request Jan 27, 2020
Closed
@pontusab pontusab requested a review from guyca January 27, 2020 19:21
@guyca guyca requested a review from yogevbd January 28, 2020 05:48
@yogevbd yogevbd merged commit b153142 into wix:master Jan 28, 2020
@pontusab pontusab deleted the on-tab-press-event branch January 28, 2020 12:03
vshkl pushed a commit to vshkl/react-native-navigation that referenced this pull request Feb 5, 2020
@pontusab @yogevbd @vshkl
On tab press event (wix#5880)
b2b6f76 
* Open modal from tab iOS

* Open modal from tab Android

* Remove playground changes

Co-authored-by: Yogev Ben David <[email protected]>
@eightyfive
Copy link

Is it part of a release?

@guyca
Copy link
Collaborator

guyca commented Feb 6, 2020

4.7.0

@eightyfive
Copy link

Awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guyca guyca Awaiting requested review from guyca

@yogevbd yogevbd Awaiting requested review from yogevbd

Assignees
No one assigned
Labels
platform: Android platform: iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pontusab @eightyfive @guyca @yogevbd