Fix wallaby #5917
Merged
Fix wallaby #5917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guyca
requested changes
Feb 10, 2020
guyca
approved these changes
Feb 10, 2020
jinshin1013
pushed a commit
to jinshin1013/react-native-navigation
that referenced
this pull request
Feb 24, 2020
* Fix wallaby * Add coverage on tsx files * Update lib/src/commands/OptionsProcessor.test.ts Co-authored-by: Guy Carmeli <[email protected]>
yogevbd
added a commit
that referenced
this pull request
Feb 24, 2020
* [iOS] Added componentName to be passed to modalDismissedEvent * Added componentName to the ModalDismissedEvent type. * Updated the JS test. * Updated the Playground Podfile.lock. * Updated the doc. * Fixed dismissedMultipleModals not having a name. * Made componentName optional for ModalDismissedEvent. * Initial Android implementation * Revert Android e2e emulator name * Revert iOS Podfile * Podfile * Setting OCMock to 3.4.3 * Fixed the documentation. * Fixed requested changes * Updated the doc. * Now emitting componentName for dismissAllModals event. * Retriggering build * Revert * Move all topBar.title options to topBarTitlePresenter (#5883) Fix TopBar title animation. This commit changes how RNN handles title and subtitle. Until now, RNN created a custom view for title and subtitle which interfered with the way the system animated the TopBar title. With this commit the custom view is created only when both subtitle and title are declared, otherwise RNN uses the system behavior. * make dotIndicator to respect visible value (#5884) In Android dotIndicator with initial value of visible: false is not respected and the dot appears in any case. Co-authored-by: Guy Carmeli <[email protected]> * Update default value for fontsize in navigation title and subtitle (#5868) Co-authored-by: Yogev Ben David <[email protected]> * v0.62 Support (#5795) react native 0.62 Support * Fix bottomTab merging options with default (#5885) When updating bottomTab options with mergeOptions - default options were not taken into account and therefore were not applied to the newly created tabBarItem * Update package.json version to 4.6.1 [ci skip] * Update package.json version to 4.7.0 [ci skip] * Fix external components layout * Move selectTabOnPress prop to correct interface (#5894) * Update changelog * External components fixes (#5896) * Fix external components layout * Fix external component navigationItem options resolving * f * Update package.json version to 4.7.1 [ci skip] * Official Gradle Wrapper Validation Action (#5901) See: https://github.com/gradle/wrapper-validation-action * temporarily disable workflows * Support react-native-youtube (#5903) react-native-youtubte is a popular library which wraps the native youtube library. The native lib attempts to detect if the player is hidden behind other views in order to prevent developers from playing videos in the background. Since the overlay container was always attached to hierarchy, the library stopped playback as it mistakingly detected the player was used in the background. This commit simply attaches the overlay container only when needed so as long as no overlays are displayed, the lib can be used. * apply extendedLayoutIncludesOpaqueBars true on all viewControllers (#5906) * Update package.json version to 4.8.0 [ci skip] * Fix overlays touch interception on new iPads (#5908) * Fix NPE when showing Overlay (#5909) Co-authored-by: Yogev Ben David <[email protected]> * Update package.json version to 4.8.1 [ci skip] * Update changelog * Allow reset topBar.title.color when color isn't provided (#5910) * Allow topBar.title.color reset when color isn't provided * Reset to nil color * Merge topBar options with default * Fix topBar options merging Co-authored-by: Guy Carmeli <[email protected]> * Update package.json version to 4.8.2 [ci skip] * Update package.json version to 4.8.3 [ci skip] * Fix wallaby (#5917) * Fix wallaby * Add coverage on tsx files * Update lib/src/commands/OptionsProcessor.test.ts Co-authored-by: Guy Carmeli <[email protected]> * Fix topBar options merging with default (#5918) * Add missing function * Update package.json version to 4.8.4 [ci skip] * Update changelog * v5 (#5931) Merge v5 into master Highlights of this release * Easier installation * autolink and reac-native link support * Shared Element Transition - reimplemented from scratch and new API * [iOS] showModal animation api parity * [Android] Animation values are now declared in dp * [iOS] deprecate topBar.drawBehind * [Android] RNN is migrating to Kotlin closes #5904 * Update package.json version to 5.0.0 [ci skip] * Adapt installation guide to v5 * Update installation guide Forgot to add Kotlin plugin * Fix compilation issue when using react native 0.62 Fixes #5933 * Update package.json version to 5.0.1 [ci skip] * Add deprecateDrawBehind option (#5934) * Add deprecateDrawBehind option * Apply draw behind options when deprecateDrawBehind equals false Co-authored-by: Guy Carmeli <[email protected]> * [v5][docs][showcases] starter kit (#5936) Hey! I have updated RNN version to the latest one (5.0.1 by the time) Hope someone will find it useful 🤩 * Add window.backgroundColor option (#5942) * Update package.json version to 5.1.0 [ci skip] * Fix crash when mergeOptions were called before stack view was created (#5945) Co-authored-by: Yogev Ben David <[email protected]> * Apply extendedLayoutIncludesOpaqueBars true on all viewControllers * Update package.json version to 5.1.1 [ci skip] * Update Android alert * Fix custom push animations (#5947) Custom push animations broke after refactoring Shared Element Transition. Fixes #5943 * Layout background color (#5946) * Apply layout.backgroundColor on parent view controllers * Add layout.componentBackgroundColor * Remove drawBehind deprecation * Update package.json version to 6.0.0 [ci skip] * Update changelog * Fix applying drawBehind through mergeOptions (#5951) mergeOptions did not handle bottomTabs.drawBehind options properly - the ReactRootView wasn't remeasured. * Update package.json version to 6.0.1 [ci skip] * Add slide animation to playground app * [iOS] Added componentName to be passed to modalDismissedEvent * Added componentName to the ModalDismissedEvent type. * Updated the JS test. * Updated the Playground Podfile.lock. * Updated the doc. * Fixed dismissedMultipleModals not having a name. * Made componentName optional for ModalDismissedEvent. * Initial Android implementation * Revert Android e2e emulator name * Revert iOS Podfile * Podfile * Setting OCMock to 3.4.3 * Fixed the documentation. * Fixed requested changes * Updated the doc. * Now emitting componentName for dismissAllModals event. * Retriggering build * Revert * Fix dismissedMultipleModals componentName * Undo OCMock hard version * Updated Podfile Co-authored-by: Guy Carmeli <[email protected]> Co-authored-by: Yogev Ben David <[email protected]> Co-authored-by: Ioannis Tsampoulatidis <[email protected]> Co-authored-by: Mary Jenel <[email protected]> Co-authored-by: Jason Safaiyeh <[email protected]> Co-authored-by: wixmobile <[email protected]> Co-authored-by: Roberto Tatasciore <[email protected]> Co-authored-by: Jonathan Leitschuh <[email protected]> Co-authored-by: ʙ ᴀ ᴛ ʀ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.