Stop rejecting on dismissAllModals if no modals are displayed #5991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds parity with iOS which does not reject the promise if dismissAllModals is called while no modals are displayed.
yogevbd
approved these changes
Mar 3, 2020
guyca
added a commit
that referenced
this pull request
Mar 18, 2020
When no modals are displayed and dismissAllModals is called, resolve the promise successfully. This regression was introduced in #5991
stachu2k
pushed a commit
to stachu2k/react-native-navigation
that referenced
this pull request
Apr 8, 2020
This commit adds parity with iOS which does not reject the promise if dismissAllModals is called while no modals are displayed.
stachu2k
pushed a commit
to stachu2k/react-native-navigation
that referenced
this pull request
Apr 8, 2020
When no modals are displayed and dismissAllModals is called, resolve the promise successfully. This regression was introduced in wix#5991
stachu2k
pushed a commit
to stachu2k/react-native-navigation
that referenced
this pull request
Apr 8, 2020
stachu2k
pushed a commit
to stachu2k/react-native-navigation
that referenced
this pull request
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds parity with iOS which does not reject the promise if dismissAllModals is called while no modals are displayed.