Fix showing Modal from TopBar components in RN 62 #6199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RNN mistakingly considered Modals as yellow boxes and removed them. Apparently this error surfaced in RN62
guyca
force-pushed
the
fixYellowBoxDelegate
branch
from
50526be
to
699f5d2
Compare
guyca
force-pushed
the
fixYellowBoxDelegate
branch
2 times, most recently
from
3879181
to
09ad037
Compare
guyca
force-pushed
the
fixYellowBoxDelegate
branch
from
09ad037
to
e9474b1
Compare
yogevbd
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When showing React Native's Modal from a TopBar component - RNN mistakingly considered Modals as yellow boxes and removed them. Apparently this error surfaced in RN62