Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bottomTabs visibility #6230

Merged
merged 8 commits into from
May 26, 2020
Merged

Fix bottomTabs visibility #6230

merged 8 commits into from
May 26, 2020

Conversation

yogevbd
Copy link
Collaborator

@yogevbd yogevbd commented May 20, 2020 •
edited
Loading

  • Fix setting root with bottomTabs.visible false
  • Fix bottomTabs invisible after hiding through mergeOptions

on iOS, setting root with invisible bottomTabs doesn't work out of the box. We had to change the implementation and load the bottomTabsController children after it has been loaded to the window's rootViewController.

@guyca guyca self-requested a review May 20, 2020 13:21
@guyca guyca self-assigned this May 20, 2020
@yogevbd yogevbd changed the title Fix setting root with bottomTabs.visible false Fix bottomTabs visibility May 21, 2020
@guyca guyca merged commit 4e1ac71 into master May 26, 2020
@guyca guyca deleted the fixBottomTabs branch May 26, 2020 08:45
@micheleb micheleb mentioned this pull request Jun 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guyca guyca guyca approved these changes

Assignees

@guyca guyca

Labels
platform: iOS type: accepted/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yogevbd @guyca