Support animating shared elements on pop #6385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create ElementTransitions when creating SharedElementAnimator, not before.
* Set correct bounds on the image being animated * Set focus point so animating different scale types looks as expected
* Remove white background * Fix title being clipped during return transition
Images flickered sometimes when popping with SET
We're not cleaning up properly after our selves and the Interpolating ScaleType remains on the image. Since this scale type is a decorator, when the decoration chain grows our of hand the animation starts to lag.
Avoid searching for transition views in both appearing and disappearing ViewControllers
yogevbd
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support to run shared element transition animations on stack pop.