Fix default modalPresentationStyle on < iOS 13 #6494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the default from overFullScreen to fullScreen on iOS 12 and below. According to wix#5709 > Below iOS 13, the default presentation style is always fullScreen presentation style. Also looking at the blame it was indeed "fullScreen" not "overFullScreen" This is also inline with the docs https://wix.github.io/react-native-navigation/api/options-root#modalpresentationstyle > The default presentation style is different on each platform. > iOS 12 and below - fullScreen > iOS 13 and above - pageSheet
yogevbd
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the default from overFullScreen to fullScreen on iOS 12 and below.
According to #5709
Also looking at the blame it was indeed "fullScreen" not "overFullScreen"
This is also inline with the docs https://wix.github.io/react-native-navigation/api/options-root#modalpresentationstyle