Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SET if image has not yet been loaded #7079

Merged
merged 1 commit into from
Apr 11, 2021

Conversation

mrousavy
Copy link
Collaborator

@mrousavy mrousavy commented Apr 9, 2021

Fixes #7078.

@yogevbd was there a specific reason to only account for the Image Scale in UIViewContentModeScaleAspectFit? All other contentModes just used the image width/height without dividing by it's scale. I changed it so that now every contentMode respects the scale.

@yogevbd yogevbd merged commit 0c97477 into master Apr 11, 2021
@yogevbd yogevbd deleted the fix-set-image-not-yet-loaded branch April 11, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared Element Transition crashes if image is not yet loaded
2 participants