Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dateTime mode in DateTimePicker #2522

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rdougan
Copy link

@rdougan rdougan commented Mar 9, 2023

Description

Updating DateTimePicker to support the dateTime mode. Added dateTimeFormat and dateTimeFormatter to DateTimePicker.

Changelog

Updating DateTimePicker to support the dateTime mode. Added dateTimeFormat and dateTimeFormatter to DateTimePicker.

@Inbal-Tish
Copy link
Collaborator

Inbal-Tish commented Mar 29, 2023

@rdougan Hi. Thank you for the PR. DateTimePicker 'datetime' mode is iOS only feature (will default to 'date' mode on Android). This should be mentioned in the mode prop. Also, the type of the 'mode' prop should be changed as well to include datetime option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants