Support overriding backgroundColor for SortableListItem #3255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
approved these changes
Sep 12, 2024
| @@ -84,7 +84,8 @@ const SortableList = <ItemT extends SortableListItemProps>(props: SortableListPr | |||
| enableHaptic, | |||
| scale | |||
| }; | |||
| }, [data]); | |||
| }, [data, onChange]); | |||
There was a problem hiding this comment.
Did this cause a bug (it looks like this is only affected by the user changing onOrderChange)?
There was a problem hiding this comment.
You mean it's on purpose?
But if the user changes the onOrderChange, it's not implausible
ethanshar
added
the
Important for Next Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support overriding backgroundColor for SortableListItem
Also fixed several TS issues
Changelog
Support overriding backgroundColor for SortableListItem
Additional info