Infra/rn73 #3264
Draft
Infra/rn73 #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
requested review from
Inbal-Tish,
adids1221,
M-i-k-e-l and
nitzanyiz
Inbal-Tish
reviewed
Sep 25, 2024
| @@ -104,7 +104,7 @@ describe('Incubator.Dialog sanity checks', () => { | |||
| const onDismiss = jest.fn(); | |||
| const component = <TestCase2 onDismiss={onDismiss}/>; | |||
| const {dialogDriver} = getDriver(component); | |||
| expect(dialogDriver.exists()).toBeTruthy(); | |||
| expect(dialogDriver.exists()).toBeFalsy(); | |||
There was a problem hiding this comment.
You need to change the description of the test - Modal should not exist...
Inbal-Tish
reviewed
Sep 25, 2024
| const {renderTree, testID} = props; | ||
|
|
||
| const driver = usePressableDriver(useComponentDriver({renderTree, testID})); | ||
| const isUsingDialog = !!renderTree.queryByTestId(`${testID}.overlay.modal`); | ||
| // const isUsingDialog = !!renderTree.queryByTestId(`${testID}.overlay.modal`); | ||
| const isUsingDialog = useDialog; |
There was a problem hiding this comment.
Why we need isUsingDialog const now?
Inbal-Tish
reviewed
Sep 25, 2024
| export interface ComponentProps { | ||
| renderTree: ReturnType<typeof within>; // Note: This changed was asked for integration with amino. This still gives all querying functionality. | ||
| testID: string | RegExp; | ||
| } | ||
|
|
||
| export interface ComponentDriverResult { | ||
| getElement: () => ReactTestInstance; | ||
| queryElement:() => ReactTestInstance | undefined; |
There was a problem hiding this comment.
Missing a space after the colon
|
@ethanshar Looks good. Left super small comments and you need to take it out of draft mode |
adids1221
reviewed
Sep 29, 2024
| @@ -42,11 +42,11 @@ export type CardProps = ViewProps & | |||
| /** | |||
| * card custom width | |||
| */ | |||
| width?: number | string; | |||
| width?: DimensionValue; | |||
There was a problem hiding this comment.
DimensionValue doesn't support string value without %.
Do we want to remove the string support from these props?
Relevant for all the components with DimensionValue type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I know it's a huge PR, I suggest going over it by commits
There are other less important small commits in between...
Changelog
Upgrade support to React Native 0.73
Additional info