Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install translate folder to enable translation everywhere #1383

Merged
merged 2 commits into from
Dec 31, 2023
Merged

Install translate folder to enable translation everywhere #1383

merged 2 commits into from
Dec 31, 2023

Conversation

wkentaro
Copy link
Owner

@wkentaro wkentaro commented Dec 31, 2023 •
edited
Loading

  • fix(i18n): add qm files to runtime
  • Add translate folder to package_data

Close #1366

Thanks @xiyaowong

@wkentaro wkentaro self-assigned this Dec 31, 2023
@wkentaro wkentaro merged commit 3c8c457 into main Dec 31, 2023
6 checks passed
@wkentaro wkentaro deleted the patch-1 branch December 31, 2023 04:35
@wkentaro wkentaro added fix pr and removed enhancement pr labels Dec 31, 2023
@wkentaro wkentaro changed the title Install translate folder Install translate folder to enable translation when installed via binary / pip install non editable Dec 31, 2023
@wkentaro wkentaro changed the title Install translate folder to enable translation when installed via binary / pip install non editable Install translate folder Dec 31, 2023
@wkentaro wkentaro added feature pr and removed fix pr labels Dec 31, 2023
@wkentaro wkentaro changed the title Install translate folder Install translate folder to enable translation everywhere Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wkentaro wkentaro

Labels
feature pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkentaro @xiyaowong