Store valuation date in UTC #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All external payments now store their valuation date as (or rather the time zone that's returned by he ValuationDateTimeZone) factory class. Previously, the time zone information was just dropped, leading to inaccurate valuation dates. This lead to troubles in the accounting department where the PayPal payments (sent in PDT time zone) were off by a day for a period of 6-8 hours. The database column doesn't store the timezone information (and doesn't need to, now that we've standardized on UTC).
moiikana
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All external payments now store their valuation date as (or rather the
time zone that's returned by he ValuationDateTimeZone) factory class.
Previously, the time zone information was just dropped, leading to
inaccurate valuation dates. This lead to troubles in the accounting
department where the PayPal payments (sent in PDT time zone) were off by
a day for a period of 6-8 hours.
The database column doesn't store the timezone information (and doesn't
need to, now that we've standardized on UTC).
https://phabricator.wikimedia.org/T349928