Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

self-references may not be discoverable by grep #1

Merged
merged 1 commit into from
Apr 18, 2018
Merged

self-references may not be discoverable by grep #1

merged 1 commit into from
Apr 18, 2018

Conversation

veprbl
Copy link

@veprbl veprbl commented Aug 11, 2017

No description provided.

wmertens
wmertens reviewed Aug 12, 2017
View reviewed changes
Copy link
Owner

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, Nix uses grepping to find out what the dependencies are after a build, and that hasn't been a problem so far. In a way, it is desireable to find out the build breaks when the symlink is absent, because that would be a source of non-determinism…

@veprbl
Copy link
Author

veprbl commented Aug 12, 2017 •
edited
Loading

Strictly speaking, self-references are not a source of non-determinism. If self-reference is not caught, the intensional store will just not deduplicate some outputs, which acceptable. Having a safenet to ensure that such software continues to work could perhaps save human time, so it is not wasted on debugging.

@wmertens wmertens merged commit 53baec8 into wmertens:master Apr 18, 2018
@wmertens
Copy link
Owner

True - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens wmertens left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veprbl @wmertens