Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mamba environment #448

Merged
merged 6 commits into from
Dec 22, 2021
Merged

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Jun 11, 2021

Closes #444.

Initial prototype, no docs or tests yet. Does this look like a good way to do it?

@henryiii
Copy link
Collaborator Author

Does this look like a good direction? Happy to polish it off if so. Also, shouldn't mamba fall back to conda if mamba is not available? I rather think so?

@henryiii
Copy link
Collaborator Author

henryiii commented Sep 9, 2021

@theacodes any direction here on the way you'd like it to go?

@theacodes
Copy link
Collaborator

Ah, I'm sorry this kept flying under my radar. This approach is great.

@henryiii henryiii marked this pull request as ready for review December 17, 2021 21:53
@henryiii
Copy link
Collaborator Author

This implementation is just a simple "mamba" can be chosen implementation - it does not auto-switch to conda if mamba is not available, or install mamba for you. A user could detect this when setting the backend in their noxfile.py, though, if that was important to them, and one of those two things could be added later if commonly used.

Copy link
Collaborator

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @henryiii

Minor nit for the docs, otherwise this looks good to me! Good call about PassthroughEnv also needing conda_cmd.

docs/tutorial.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🚀

@cjolowicz cjolowicz merged commit 2a19748 into wntrblm:main Dec 22, 2021
@henryiii henryiii deleted the henryiii/feat/mamba branch December 22, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

conda: support for Mamba
4 participants