Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setup.py #458

Merged
merged 4 commits into from
Jul 4, 2021
Merged

Remove setup.py #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4788834
Remove setup.py
cjolowicz Jun 20, 2021
39e2d19
Remove setup.py from blacken and lint sessions
cjolowicz Jun 20, 2021
e4d72fc
CI: Use python -m build in deploy job
cjolowicz Jun 20, 2021
2726106
Merge branch 'main' into remove-setup-py
cjolowicz Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@ jobs:
uses: actions/setup-python@v2
with:
python-version: 3.9
- name: Install setuptools and wheel
run: python -m pip install --upgrade --user setuptools wheel
- name: Install build
run: python -m pip install --user build
- name: Build sdist and wheel
run: python setup.py sdist bdist_wheel
run: python -m build
Comment on lines 59 to +65
Copy link
Collaborator

@henryiii henryiii Jun 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these lines can be replaced with:

- name: Build sdist and wheel
  run: pipx run build

GHA supports pipx without setup-python, and build supports pipx too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, thanks! I'd like to keep the scope of this PR restricted to removing setup.py, but feel free to open an issue.

- name: Publish distribution PyPI
uses: pypa/gh-action-pypi-publish@master
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend pinning this and then using dependabot to update it every so often (it doesn't change that often).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Dependabot is a great idea, I think there are more places where we could benefit from it. As with your other suggestion, I'd prefer to handle this in a separate PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to make those in a followup if (since) you like the ideas.

with:
Expand Down
4 changes: 2 additions & 2 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def cover(session):
def blacken(session):
"""Run black code formatter."""
session.install("black==21.5b2", "isort==5.8.0")
files = ["nox", "tests", "noxfile.py", "setup.py"]
files = ["nox", "tests", "noxfile.py"]
session.run("black", *files)
session.run("isort", *files)

Expand All @@ -96,7 +96,7 @@ def lint(session):
"importlib_metadata",
)
session.run("mypy")
files = ["nox", "tests", "noxfile.py", "setup.py"]
files = ["nox", "tests", "noxfile.py"]
session.run("black", "--check", *files)
session.run("isort", "--check", *files)
session.run("flake8", *files)
Expand Down
17 changes: 0 additions & 17 deletions setup.py
View file
Open in desktop

This file was deleted.