-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pre-commit deps, to fix a breaking Click update #590
Conversation
This fixes an issue with a breaking Click update.
Ah... this crashed with something I didn't expect...
|
I hope this will fix the last Click incompatibility.
Ok, I reported this at hadialqattan/pycln#116. By now, I'll try to reduce Click to a lower version for running |
This could be a temporary solution to the pycln issue.
You can fix it by adding a cap on click inside the pycln environment. See https://github.com/pybind/pybind11/pull/3831/files. It's actually typer's fault in fastapi/typer#377, not pycln. |
Good to hear that, thanks @henryiii! |
I think this is ready now. |
I see that Typer will get fixed soon (fastapi/typer#380). So, I think we can remove the Click downgrading and just upgrade some deps :) |
27 minutes ago, yes. :) |
I just released Typer |
Typer has just fixed its issue :)
All done :) |
I'm gonna merge this, since it looks like nobody disagrees :D |
This fixes an issue with a breaking Click update.
See psf/black#2964 for full details.