Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use setup-python v4.1's environmentless setup #629

Merged
merged 6 commits into from
Jul 13, 2022
Merged

fix: use setup-python v4.1's environmentless setup #629

merged 6 commits into from
Jul 13, 2022

Conversation

henryiii
Copy link
Collaborator

This removes the dependence on the final output being reasonable to run nox. Targeting only <3.7 is valid now.

CC @mayeut

@henryiii
fix: use setup-python v4.1's environmentless setup
3a9bd5f 
This removes the dependence on the final output being reasonable to run nox. Targeting only <3.7 is valid now.
@henryiii
fix: mistake in YAML syntax
adde802
@henryiii
Copy link
Collaborator Author

henryiii commented Jul 11, 2022 •
edited
Loading

v4 isn't pointing at v4.1.0 yet. Will update the spurious space once that updates. Will make un-draft when that happens; let's try v4.1.0.

@henryiii henryiii marked this pull request as draft July 11, 2022 22:21
@henryiii henryiii marked this pull request as draft July 11, 2022 22:21
@henryiii henryiii marked this pull request as ready for review July 12, 2022 14:02
@henryiii
Copy link
Collaborator Author

v4 has been updated.

FollowTheProcess
FollowTheProcess approved these changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@FollowTheProcess FollowTheProcess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @henryiii thanks!

DiddiLeija
DiddiLeija approved these changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @henryiii!

@FollowTheProcess FollowTheProcess merged commit f630e2d into wntrblm:main Jul 13, 2022
@mayeut
Copy link
Contributor

mayeut commented Jul 14, 2022 •
edited
Loading

Sorry I did not have time to review this until today.
I opened #632 to fix the environmentless setup of the localpython step, GHA only warns on invalid input names.

One thing worth mentioning is that with this, the nox action won't honor the python version specified by the user as an input of the action for the major.minor version used to install nox, it will just use the localpython one. probably 99.9% of the times, they will be the same so that's not really an issue in the real world but at least worth mentioning. c.f. https://github.com/mayeut/nox/actions/runs/2669299285

@mayeut mayeut mentioned this pull request Jul 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FollowTheProcess FollowTheProcess FollowTheProcess approved these changes

@DiddiLeija DiddiLeija DiddiLeija approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@henryiii @mayeut @FollowTheProcess @DiddiLeija