Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export session name in envvar NOX_CURRENT_SESSION #641

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Export session name in envvar NOX_CURRENT_SESSION #641

merged 1 commit into from
Aug 4, 2022

Conversation

ktbarrett
Copy link
Contributor

Closes #636. The environment variable NOX_CURRENT_SESSION is populated with the name of the current session in all subcommands of that session.

There were a couple places to place this small bit of code. Each location caused some problems with the existing tests. The current place was chosen because it intuitively makes sense to take code that the user would write at the top of their session functions and move it up into the thing that calls the session function. Let me know if you think it belongs elsewhere.

Copy link
Collaborator

@FollowTheProcess FollowTheProcess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice and clean implementation, great work!

Copy link
Collaborator

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ktbarrett!

@FollowTheProcess FollowTheProcess merged commit 5eecc52 into wntrblm:main Aug 4, 2022
@ktbarrett ktbarrett deleted the export-session-name branch August 4, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Set environment variable when running commands
3 participants