-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point action docs to 2022.8.7 not latest #664
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you both @FollowTheProcess and @henryiii!
Small question: Is @main
possible, instead of @latest
? If not, I'm ok with merging this 👍
Ahh sorry, I didn't read #662 yet :/ |
|
Ok. I'm personally more comfortable with |
A specific tag is always preferable IMO, it means a user of the action is always getting an exact version rather than whatever is on the main branch (which may, although unlikely, break). What do we think? If we need to keep it up to date with new versions there's things like bump2version that can find and replace, or we just leave it with a comment that says e.g "any tagged version will work here" |
That would resolve my concerns of using a specific tag! |
Fixes a mention in the docs to
@latest
which doesn't actually refer to a valid tag, my bad for not spotting! 👍🏻 Thanks @henryiii