Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't error if not installing to passthrough #809

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Apr 6, 2024

If you have a passthrough environment and have passed --no-install, don't error because there's an install command that's not going to do anything.

Fixes #739. This fixes the underlying problem in #693 - that was asking for a way to detect run("pip", "install", ...) precisely because this bug kept .install(...) from being usable.

@henryiii henryiii merged commit 11dac8c into wntrblm:main Apr 7, 2024
22 checks passed
@henryiii henryiii deleted the henryiii/fix/noinstallpassthrough branch April 7, 2024 20:08
@henryiii henryiii mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Allow combination of --no-venv and --no-install to suppress error on session.install
2 participants