Use :finch value to override finch instance (#391)

wojtekmach · Jul 18, 2024 · 71bb9ae · 71bb9ae
1 parent ef8bd82
commit 71bb9ae
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/lib/req/finch.ex b/lib/req/finch.ex
@@ -309,8 +309,12 @@ defmodule Req.Finch do
       Map.has_key?(request.options, :connect_options) or Map.has_key?(request.options, :inet6)
 
     cond do
-      request.options[:finch] && custom_options? ->
-        raise ArgumentError, "cannot set both :finch and :connect_options"
+      name = request.options[:finch] ->
+        if custom_options? do
+          raise ArgumentError, "cannot set both :finch and :connect_options"
+        else
+          name
+        end
 
       custom_options? ->
         pool_options = pool_options(request.options)

diff --git a/test/req/finch_test.exs b/test/req/finch_test.exs
@@ -183,6 +183,12 @@ defmodule Req.FinchTest do
       end
     end
 
+    test ":finch option" do
+      assert_raise ArgumentError, "unknown registry: MyFinch", fn ->
+        Req.get!("http://localhost", finch: MyFinch)
+      end
+    end
+
     test ":finch and :connect_options" do
       assert_raise ArgumentError, "cannot set both :finch and :connect_options", fn ->
         Req.request!(finch: MyFinch, connect_options: [timeout: 0])