Fix displaying redacted basic auth

wojtekmach · Aug 18, 2023 · 7ad4bc8 · 7ad4bc8
1 parent c89e8c6
commit 7ad4bc8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/req/request.ex b/lib/req/request.ex
@@ -845,7 +845,7 @@ defmodule Req.Request do
                 %{request.options | auth: {:bearer, "[redacted]"}}
 
               %{auth: {_username, _password}} ->
-                %{request.options | auth: {["redacted"], "[redacted]"}}
+                %{request.options | auth: {"[redacted]", "[redacted]"}}
 
               _ ->
                 request.options

diff --git a/test/req_test.exs b/test/req_test.exs
@@ -49,6 +49,8 @@ defmodule ReqTest do
   test "redact" do
     assert inspect(Req.new(auth: {:bearer, "foo"})) =~ ~s|auth: {:bearer, "[redacted]"}|
 
+    assert inspect(Req.new(auth: {"foo", "bar"})) =~ ~s|auth: {"[redacted]", "[redacted]"}|
+
     assert inspect(Req.new(headers: [authorization: "bearer foo"])) =~
              ~s|{"authorization", "[redacted]"}|
   end