-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Req.Request
, Req.Response
: Change headers to be maps
#224
Conversation
3e3e418
to
675f138
Compare
Hi @wojtekmach, thanks for all the work put into We're in the processing of migrating from 0.3 to 0.4, and in the process I assumed that the
Is there a specific reason that these values are still lists in 0.4.x? |
Both are supported! (If maps are not, it’s a bug.) the idea is passing eg |
In hindsight this is not necessarily super obvious so a PR that updates docs is welcome as always! |
Ah, thanks! Would you like me to replace the existing |
@wojtekmach See #241 for PR, feel free to change anything you like! |
Closes #223