Fix incorrect put_header doctest (& re-enable the doctest)
#274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the doc during a work task and found that the
put_headerdoc was still referencing "non-map" (pre 0.4) headers format.Instead of just fixing it, I preferred to understand why the test was not failing in the first place, discovered that it was disabled, re-enabled it and fixed it.
Unsure if I missed something (re:
Req.MixProject.legacy_headers_as_lists?in particular), or other motivations which may have lead to that specific doctest being disabled, so feel free to adapt!