Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include custom ports in aws_sigv4_* functions #405

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

fahchen
Copy link
Contributor

@fahchen fahchen commented Aug 10, 2024

Presigned URLs should remain valid across custom endpoint ports (e.g., 9000 instead of the standard 80 or 443) by including port numbers in the host header.

For related discussions in other repositories, see:

lib/req/utils.ex Outdated Show resolved Hide resolved
test/req/utils_test.exs Outdated Show resolved Hide resolved
test/req/utils_test.exs Outdated Show resolved Hide resolved
@wojtekmach wojtekmach merged commit 48b4513 into wojtekmach:main Aug 13, 2024
2 checks passed
@wojtekmach
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants