[breaking] Implement controlled component support #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
wojtekmaj
commented
Jul 27, 2019
wojtekmaj
commented
- Implement defaultValue, defaultView, defaultActiveStartDate
- Add onViewChange callback
- Rename onActiveDateChange to onActiveStartDateChange
- Prioritize activeStartDate over value when getting default active start date
wojtekmaj
force-pushed
the
controlled-calendar
branch
2 times, most recently
from
8044f7b
to
713d140
Compare
wojtekmaj
force-pushed
the
controlled-calendar
branch
from
713d140
to
21c79c7
Compare
* Implement defaultValue, defaultView, defaultActiveStartDate * Add onViewChange callback * Rename onActiveDateChange to onActiveStartDateChange * Prioritize activeStartDate over value when getting default active start date
wojtekmaj
force-pushed
the
controlled-calendar
branch
from
21c79c7
to
b5997ef
Compare
felixmosh
pushed a commit
to felixmosh/react-calendar
that referenced
this pull request
Nov 8, 2020
* Implement defaultValue, defaultView, defaultActiveStartDate * Add onViewChange callback * Rename onActiveDateChange to onActiveStartDateChange * Prioritize activeStartDate over value when getting default active start date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.