boost TX_FIFO_SIZE to 300kb #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdc drops written packets if fifo is full.. which is easily achieved when starving the mcu. try pasting >512 bytes into micropython before this patch.
|
Thanks! However, I think it will make more sense, in this case, to dynamically allocate/extend the FIFO based on usage. Otherwise, 300k is just as arbitrary as 512 bytes. |
|
yeah sure just shared it in case it bugs other people anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wondered why I can't paste into the micropython demo chunks longer than 512 bytes. then I read the code and figured out the fifo is too small, and when pasting data the mcu green thread is starving, and data starts to leak. boosting this const up allows pasting longer text easily.