Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt/11.0.0 package update #22932

Closed
wants to merge 2 commits into from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Jul 1, 2024

Signed-off-by: wolfi-bot <[email protected]>
@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Jul 1, 2024
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Package fmt: Click to expand/collapse

Package fmt:
Added: /usr/lib/libfmt.so.11.0.0
Deleted: /usr/lib/libfmt.so.10.2.1

Package fmt-dev: Click to expand/collapse

Package fmt-dev:
Added: /usr/include/fmt/base.h
Modified: /usr/include/fmt/args.h
Modified: /usr/include/fmt/chrono.h
Modified: /usr/include/fmt/color.h
Modified: /usr/include/fmt/compile.h
Modified: /usr/include/fmt/core.h
Modified: /usr/include/fmt/format-inl.h
Modified: /usr/include/fmt/format.h
Modified: /usr/include/fmt/os.h
Modified: /usr/include/fmt/ostream.h
Modified: /usr/include/fmt/printf.h
Modified: /usr/include/fmt/ranges.h
Modified: /usr/include/fmt/std.h
Modified: /usr/include/fmt/xchar.h
Modified: /usr/lib/cmake/fmt/fmt-config-version.cmake
Modified: /usr/lib/cmake/fmt/fmt-targets-minsizerel.cmake
Modified: /usr/lib/pkgconfig/fmt.pc

bincapz found differences: Click to expand/collapse

Added: fmt-dev/usr/include/fmt/base.h [✅ LOW]

RISK KEY DESCRIPTION EVIDENCE
+LOW ref/site/url contains embedded HTTPS URLs https://fmt.dev/latest/api.html
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59884
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61414
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67371.
fmtlib/fmt#1628
fmtlib/fmt#3247
fmtlib/fmt#3796
fmtlib/fmt#2297
fmtlib/fmt#2582
https://godbolt.org/z/GvWzcTjh1.
https://godbolt.org/z/sWw4vP.
https://herbsutter.com/2009/10/18/mailbag-shutting-up-compiler-warnings/.

Copy link
Contributor Author

octo-sts bot commented Jul 1, 2024

Open AI suggestions to solve the build error:

The log file does not contain any error messages.

Copy link
Contributor Author

octo-sts bot commented Jul 4, 2024

Open AI suggestions to solve the build error:

The error message is: 

In file included from /home/build/libmamba/include/mamba/api/install.hpp:22,
from /home/build/micromamba/src/run.cpp:18:
/home/build/libmamba/include/mamba/core/repo.hpp:91:59: warning: 'PyExtraPkgInfo' is deprecated [-Wdeprecated-declarations]
91 | py_add_extra_pkg_info(const std::map<std::string, PyExtraPkgInfo>& additional_info);
| ^~~~~~~~~~~~~~
/home/build/libmamba/include/mamba/core/repo.hpp:80:31: note: declared here
80 | struct [[deprecated]] PyExtraPkgInfo
| ^~~~~~~~~~~~~~
/home/build/micromamba/src/run.cpp: In lambda function:
/home/build/micromamba/src/run.cpp:76:40: error: 'join' is not a member of 'fmt'; did you mean 'CLI::detail::join'?
76 | fmt::format("{}", fmt::join(el["command"].get<std::vectorstd::string>(), " ")),
| ^~~~
In file included from /usr/include/CLI/CLI.hpp:22,
from /home/build/micromamba/src/common_options.hpp:10,
from /home/build/micromamba/src/run.cpp:24:
/usr/include/CLI/StringTools.hpp:69:13: note: 'CLI::detail::join' declared here
69 | std::string join(const T &v, Callable func, std::string delim = ",") {
| ^~~~
/home/build/micromamba/src/run.cpp:72:26: error: cannot convert '' to 'const std::vectormamba::printers::FormattedString&'
72 | table.add_row({
| ~~~~~~~~~~~~~^~
73 | el["pid"].getstd::string(),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
74 | el["name"].get<std::string()],
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
75 | prefix,
| ~~~~~~~
76 | fmt::format("{}", fmt::join(el["command"].get<std::vectorstd::string>(), " ")),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
77 | });
| ~~
In file included from /home/build/libmamba/include/mamba/core/util_scope.hpp:7,
from /home/build/libmamba/include/mamba/core/tasksync.hpp:16,
from /home/build/libmamba/include/mamba/core/context.hpp:19,
from /home/build/libmamba/include/mamba/api/configuration_impl.hpp:11,
from /home/build/libmamba/include/mamba/api/configuration.hpp:14,
from /home/build/micromamba/src/run.cpp:17:
/home/build/libmamba/include/mamba/core/output.hpp:84:62: note: initializing argument 1 of 'void mamba::printers::Table::add_row(const std::vectormamba::printers::FormattedString&)'
84 | void add_row(const std::vector& r);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
In file included from /home/build/libmamba/include/mamba/api/install.hpp:22,
from /home/build/libmamba/include/mamba/core/transaction.hpp:14,
from /home/build/micromamba/src/update.cpp:16:
/home/build/libmamba/include/mamba/core/repo.hpp:91:59: warning: 'PyExtraPkgInfo' is deprecated [-Wdeprecated-declarations]
91 | py_add_extra_pkg_info(const std::map<std::string, PyExtraPkgInfo>& additional_info);
| ^~~~~~~~~~~~~~
/home/build/libmamba/include/mamba/core/repo.hpp:80:31: note: declared here
80 | struct [[deprecated]] PyExtraPkgInfo
| ^~~~~~~~~~~~~~
In file included from /home/build/libmamba/include/mamba/api/install.hpp:22,
from /home/build/micromamba/src/constructor.cpp:11:
/home/build/libmamba/include/mamba/core/repo.hpp:91:59: warning: 'PyExtraPkgInfo' is deprecated [-Wdeprecated-declarations]
91 | py_add_extra_pkg_info(const std::map<std::string, PyExtraPkgInfo>& additional_info);
| ^~~~~~~~~~~~~~
/home/build/libmamba/include/mamba/core/repo.hpp:80:31: note: declared here
80 | struct [[deprecated]] PyExtraPkgInfo
| ^~~~~~~~~~~~~~
/home/build/micromamba/src/constructor.cpp: In function 'void read_binary_from_stdin_and_write_to_file(fs::u8path&)':
/home/build/micromamba/src/constructor.cpp:219:41: warning: conversion to 'std::streamsize' {aka 'long int'} from 'std::size_t' {aka 'long unsigned int'} may change the sign of the result [-Wsign-conversion]
219 | out_stream.write(buffer.data(), len);
| ^~~
ninja: subcommand failed
ERROR: failed to build package. the build environment has been preserved:
workspace dir: /temp/melange-workspace-1021751317
guest dir: /temp/melange-guest-2975042388
failed to build package: unable to run package libmamba pipeline: unable to run pipeline: unable to run pipeline: exit status 1
make[1]: *** [Makefile:111: packages/aarch64/libmamba-2024.03.25-r3.apk] Error 1
make[1]: Leaving directory '/github/home'
make: *** [Makefile:101: package/libmamba] Error 2
##[error]Process completed with exit code 2.


Suggested actions:
1. Replace `fmt::join` with `CLI::detail::join`.
2. Ensure `table.add_row` receives a `std::vector<mamba::printers::FormattedString>`.
3. Update deprecated `PyExtraPkgInfo` usage.
4. Fix sign-conversion warning in `constructor.cpp`.
5. Rebuild the project.

@octo-sts octo-sts bot closed this Jul 5, 2024
Copy link
Contributor Author

octo-sts bot commented Jul 5, 2024

superseded by #23233

@octo-sts octo-sts bot deleted the wolfictl-0bef3a76-1c44-4a7c-b2e5-fd6fb5decb93 branch July 6, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants