Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always use builtin pipelines for Go builds #31926

Merged

Conversation

developer-guy
Copy link
Member

@developer-guy developer-guy commented Oct 25, 2024

Once we run the binary it outputs the driverVersion wrong, so, this PR aims to fix it.

[sdk] ❯ aws-ebs-csi-driver --version
{
  "driverVersion": "1.36.0",
  "gitCommit": "e6dae6132fc8383340024440fc639a135bebd4ba",
  "buildDate": "1970-01-01T00:00:00Z",
  "goVersion": "go1.23.2",
  "compiler": "gc",
  "platform": "linux/arm64"
}
[sdk] ❯

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • This PR links to the upstream project's support policy (e.g. endoflife.date)

@developer-guy developer-guy changed the title always use builtin pipelines for Go builds -s always use builtin pipelines for Go builds Oct 25, 2024
aws-ebs-csi-driver.yaml Outdated Show resolved Hide resolved
aws-ebs-csi-driver.yaml Show resolved Hide resolved
@kranurag7 kranurag7 merged commit d9a1dec into wolfi-dev:main Oct 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants