Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jaeger/1.63.0 package update #33787

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Nov 10, 2024

Package update, plus added npm as a buildtime dependency, which is now required for this version of the package.


@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Nov 10, 2024
Copy link
Contributor Author

octo-sts bot commented Nov 10, 2024

Gen AI suggestions to solve the build error:

Based on the error output, the build is failing during the yarn install step for the jaeger-all-in-one subpackage. Here are some suggestions to fix the issue:

  1. Add npm as a build dependency:
    The error shows "/bin/sh: npm: not found" which indicates npm is missing. Add npm to the environment packages:
environment:
  contents:
    packages:
      - busybox
      - ca-certificates-bundle
      - nodejs-20
      - yarn
      - npm   # Add this line
  1. Modify the yarn build step:
    Instead of relying on npm, modify the build command to use yarn directly:
pipeline:
  - runs: |
      if [[ "${{range.key}}" = "all-in-one" ]]; then
        mkdir -p jaeger-ui/packages/jaeger-ui/build
        rm -rf cmd/query/app/ui/actual/*
        cd jaeger-ui
        yarn install --frozen-lockfile
        yarn workspace @jaegertracing/plexus build  # Use yarn workspace instead of npm
        cd packages/jaeger-ui
        yarn build
      fi
  1. Consider using workspaces:
    Since this is a monorepo setup, you might want to explicitly enable yarn workspaces by adding a workspaces field to the root package.json if it's not already there.

The main issue appears to be the missing npm dependency which is needed for the prepublish script. Adding npm to the environment packages should resolve the immediate error.

Signed-off-by: Mark McCormick <[email protected]>
Copy link
Contributor

Package jaeger-collector-compat: Click to expand/collapse

Package jaeger-collector-compat:
Unchanged

Package jaeger-ingester-compat: Click to expand/collapse

Package jaeger-ingester-compat:
Unchanged

Package jaeger-agent: Click to expand/collapse

Package jaeger-agent:
Modified: /usr/bin/agent

Package jaeger-collector: Click to expand/collapse

Package jaeger-collector:
Modified: /usr/bin/collector

Package jaeger-es-index-cleaner: Click to expand/collapse

Package jaeger-es-index-cleaner:
Modified: /usr/bin/es-index-cleaner

Package jaeger-esmapping-generator: Click to expand/collapse

Package jaeger-esmapping-generator:
Modified: /usr/bin/esmapping-generator

Package jaeger-agent-compat: Click to expand/collapse

Package jaeger-agent-compat:
Unchanged

Package jaeger-tracegen-compat: Click to expand/collapse

Package jaeger-tracegen-compat:
Unchanged

Package jaeger: Click to expand/collapse

Package jaeger:
Unchanged

Package jaeger-anonymizer: Click to expand/collapse

Package jaeger-anonymizer:
Modified: /usr/bin/anonymizer

Package jaeger-query: Click to expand/collapse

Package jaeger-query:
Modified: /usr/bin/query

Package jaeger-remote-storage: Click to expand/collapse

Package jaeger-remote-storage:
Modified: /usr/bin/remote-storage

Package jaeger-es-index-cleaner-compat: Click to expand/collapse

Package jaeger-es-index-cleaner-compat:
Unchanged

Package jaeger-es-rollover: Click to expand/collapse

Package jaeger-es-rollover:
Modified: /usr/bin/es-rollover

Package jaeger-tracegen: Click to expand/collapse

Package jaeger-tracegen:
Modified: /usr/bin/tracegen

Package jaeger-all-in-one-compat: Click to expand/collapse

Package jaeger-all-in-one-compat:
Unchanged

Package jaeger-esmapping-generator-compat: Click to expand/collapse

Package jaeger-esmapping-generator-compat:
Unchanged

Package jaeger-remote-storage-compat: Click to expand/collapse

Package jaeger-remote-storage-compat:
Unchanged

Package jaeger-all-in-one: Click to expand/collapse

Package jaeger-all-in-one:
Modified: /usr/bin/all-in-one

Package jaeger-ingester: Click to expand/collapse

Package jaeger-ingester:
Modified: /usr/bin/ingester

Package jaeger-anonymizer-compat: Click to expand/collapse

Package jaeger-anonymizer-compat:
Unchanged

Package jaeger-es-rollover-compat: Click to expand/collapse

Package jaeger-es-rollover-compat:
Unchanged

Package jaeger-query-compat: Click to expand/collapse

Package jaeger-query-compat:
Unchanged

@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Nov 10, 2024
@mamccorm mamccorm enabled auto-merge (squash) November 10, 2024 22:17
@mamccorm mamccorm merged commit 261b3bc into main Nov 11, 2024
17 checks passed
@mamccorm mamccorm deleted the wolfictl-5fb19578-1bdc-4aca-a22d-2d21b0c4ddc6 branch November 11, 2024 02:04
@mamccorm mamccorm self-assigned this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants