Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingress-nginx-controller: move binaries to use /usr/bin, remove opent… #5781

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

rawlingsj
Copy link
Member

…racing-cpp, aeger-client-cpp and nginx_ajp_module

The following projects have been deprecated so removing from wolfi and from being used in ingress-nginx-controller.

https://github.com/opentracing/opentracing-cpp
https://github.com/jaegertracing/jaeger-client-cpp

AJP support has been deprecated from the upstream ingress controller project kubernetes/ingress-nginx#10158

@rawlingsj
Copy link
Member Author

Looks like datadog-cpp and zipkin-cpp
are both dependant on the deprecated https://github.com/opentracing/opentracing-cpp

Probably need to remove these too. I've removed the open tracing module from the ingress-nginx-controller in his PR which is the only package that uses them.

https://github.com/kubernetes/ingress-nginx is moving to opentelemetry rather than opentracing.

…racing-cpp, aeger-client-cpp and nginx_ajp_module

The following projects have been deprecated so removing from wolfi and from being used in ingress-nginx-controller.

https://github.com/opentracing/opentracing-cpp
https://github.com/jaegertracing/jaeger-client-cpp

AJP support has been deprecated from the upstream ingress controller project kubernetes/ingress-nginx#10158

Signed-off-by: James Rawlings <[email protected]>
@github-actions
Copy link
Contributor

Package ingress-nginx-controller: Click to expand/collapse

Package ingress-nginx-controller:
Added: /usr/bin/nginx
Added: /usr/bin/nginx-dbg
Added: /usr/bin/nginx-ingress-controller
Added: /usr/bin/waitshutdown
Modified: /etc/nginx/modules/ngx_http_modsecurity_module.so
Deleted: /dbg
Deleted: /etc/nginx/modules/ngx_http_opentracing_module.so
Deleted: /nginx-ingress-controller
Deleted: /usr/local/nginx/html/50x.html
Deleted: /usr/local/nginx/html/index.html
Deleted: /usr/local/nginx/sbin/nginx
Deleted: /waitshutdown

Package ingress-nginx-controller-compat: Click to expand/collapse

Package ingress-nginx-controller-compat:
Unchanged

@rawlingsj rawlingsj added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit b374534 Sep 21, 2023
6 checks passed
@rawlingsj rawlingsj deleted the ingress_nginx_after_tests branch September 21, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants