Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update connect server URL in test proxy configuration #2447

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

martynmjones
Copy link
Contributor

@martynmjones martynmjones commented Jun 27, 2024

Changes proposed in this Pull Request:

Closes #2446

Updates the test proxy configuration to set the connect server URL to https://api.woocommerce.com as this was missed when the service was originally migrated.

Screenshot 2024-06-27 at 07 23 57

Detailed test instructions:

  1. Run npm run test-proxy
  2. Confirm the correct connect server URL is displayed in the output
    • Proxy server running on http://localhost:5555 > https://api.woocommerce.com in default mode
  3. Confirm the test data is displayed when viewing reports in Marketing > Google Listings & Ads

Changelog entry

Dev - Update connect server URL in test proxy configuration

@martynmjones martynmjones self-assigned this Jun 27, 2024
@github-actions github-actions bot added type: bug The issue is a confirmed bug. changelog: fix Took care of something that wasn't working. labels Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.4%. Comparing base (4d50b73) to head (3112bd3).
Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #2447   +/-   ##
=======================================
  Coverage     63.4%   63.4%           
=======================================
  Files          321     321           
  Lines         5027    5027           
  Branches      1219    1219           
=======================================
  Hits          3188    3188           
  Misses        1672    1672           
  Partials       167     167           
Flag Coverage Δ
js-unit-tests 63.4% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ianlin ianlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, tested locally and it worked as expected as described. 👍

@martynmjones martynmjones merged commit cb7765e into develop Jun 27, 2024
7 checks passed
@martynmjones martynmjones deleted the fix/2446-update-connect-server-url-test-proxy branch June 27, 2024 06:55
@eason9487 eason9487 added changelog: dev Developer-facing only change. and removed type: bug The issue is a confirmed bug. changelog: fix Took care of something that wasn't working. labels Jun 27, 2024
@jorgemd24 jorgemd24 mentioned this pull request Jul 9, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update test proxy default URL
3 participants