Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get started page #2498

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Update get started page #2498

merged 3 commits into from
Aug 7, 2024

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Aug 6, 2024

Changes proposed in this Pull Request:

This PR updates the top of getting started page to match the new content in https://woocommerce.com/products/google-listings-and-ads/

Screenshots:

Implementation in app
Screenshot 2024-08-06 at 19 56 35

Screenshot 2024-08-06 at 19 56 44

Recommendations

Screenshot 2024-08-06 at 19 57 01 Screenshot 2024-08-06 at 19 56 57

Detailed test instructions:

  1. Checkout PR and verify the changes look as the recommendations in the screenshots provided.

Additional details:

Changelog entry

Tweak - Update get started page

@puntope puntope self-assigned this Aug 6, 2024
@puntope puntope marked this pull request as ready for review August 6, 2024 17:58
@github-actions github-actions bot added the changelog: tweak Small change, that isn't actually very important. label Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.5%. Comparing base (a8e9cac) to head (70f569d).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2498      +/-   ##
============================================
- Coverage       64.7%   63.5%    -1.1%     
============================================
  Files            797     322     -475     
  Lines          22930    5043   -17887     
  Branches        1220    1220              
============================================
- Hits           14825    3204   -11621     
+ Misses          7938    1672    -6266     
  Partials         167     167              
Flag Coverage Δ
js-unit-tests 63.5% <ø> (ø)
php-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 475 files with indirect coverage changes

@puntope puntope requested a review from a team August 6, 2024 18:11
Copy link
Contributor

@martynmjones martynmjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @puntope, thanks for the update.

Tested locally and confirmed that the text and images all match what's highlighted in the Recommended screenshots.

I'm assuming this is not an issue but noting that there is one difference from the screenshot as there is still an arrow on each of the Sell more on Google buttons:

Screenshot 2024-08-06 at 21 36 30

However, I'm guessing that is intended so the changes look good to me.

@puntope
Copy link
Contributor Author

puntope commented Aug 7, 2024

However, I'm guessing that is intended so the changes look good to me.

Thx @martynmjones for that point. I will ask and if so. I will update it in further PR

@puntope puntope merged commit 7e7601b into develop Aug 7, 2024
9 checks passed
@puntope puntope deleted the tweak/update-get-started-page branch August 7, 2024 07:03
@eason9487 eason9487 mentioned this pull request Aug 14, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants