Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WPORG header image #2512

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Update WPORG header image #2512

merged 2 commits into from
Aug 8, 2024

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Aug 8, 2024

Changes proposed in this Pull Request:

This PR updates the banners with the new ones provided by Google

Screenshots:

Detailed test instructions:

  1. Check that the banners are the same size as the other 2 and match the one In https://woocommerce.com/products/google-listings-and-ads/

Additional details:

Changelog entry

Tweak - Update WPORG plugin page header image

@puntope puntope requested a review from a team August 8, 2024 09:05
@puntope puntope self-assigned this Aug 8, 2024
@puntope puntope marked this pull request as ready for review August 8, 2024 09:05
@github-actions github-actions bot added the changelog: tweak Small change, that isn't actually very important. label Aug 8, 2024
Copy link
Contributor

@mikkamp mikkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I can confirm the sizes match and the change looks good to me.

Just wanted to note that WooRelease does not update these asset images. So either we'll need to commit to svn after this PR is merged. Or leave a note for the porter that this needs to be done in combination with the release.

@mikkamp mikkamp changed the title Update WPORG header mage Update WPORG header image Aug 8, 2024
@puntope
Copy link
Contributor Author

puntope commented Aug 8, 2024

Thanks for the changes. I can confirm the sizes match and the change looks good to me.

Just wanted to note that WooRelease does not update these asset images. So either we'll need to commit to svn after this PR is merged. Or leave a note for the porter that this needs to be done in combination with the release.

Thx @mikkamp I added a not to myself for doing this tomorrow

@puntope puntope merged commit eb253cf into develop Aug 8, 2024
4 checks passed
@puntope puntope deleted the tweak/change-banner branch August 8, 2024 15:57
@eason9487 eason9487 mentioned this pull request Aug 14, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants