Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the value entering of the billing state field in e2e test compatible with WC < 9.2 #2528

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

This PR applies the same adjustment in woocommerce/woocommerce-google-analytics-integration#457 to make e2e test compatible with WC < 9.2.

image

Detailed test instructions:

  1. npm run wp-env:up
  2. npm run -- wp-env run tests-cli -- wp plugin update woocommerce --version=9.1.4 && npm run -- wp-env run tests-cli -- wp wc update
  3. npm run test:e2e
  4. Confirm tests pass
  5. npm run -- wp-env run tests-cli -- wp plugin update woocommerce --version=9.2.0-rc.1 && npm run -- wp-env run tests-cli -- wp wc update
  6. npm run test:e2e
  7. Confirm tests pass

Changelog entry

@eason9487 eason9487 self-assigned this Aug 15, 2024
@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.8%. Comparing base (fe41b5b) to head (a4d6d00).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2528      +/-   ##
============================================
- Coverage       64.7%   63.8%    -0.9%     
============================================
  Files            801     326     -475     
  Lines          22976    5086   -17890     
  Branches        1229    1229              
============================================
- Hits           14875    3247   -11628     
+ Misses          7934    1672    -6262     
  Partials         167     167              
Flag Coverage Δ
js-unit-tests 63.8% <ø> (ø)
php-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 475 files with indirect coverage changes

@eason9487
Copy link
Member Author

Ran e2e test with WooCommerce 9.1.4 and 9.2.0-rc.1 via GitHub actions:

I will be merging this PR without code reviews.

@eason9487 eason9487 merged commit 5af0314 into develop Aug 15, 2024
11 checks passed
@eason9487 eason9487 deleted the dev/compat-e2e-billing-state-input branch August 15, 2024 10:53
@jorgemd24 jorgemd24 mentioned this pull request Aug 20, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant