Rename "api" to "woo-api" and "e2e" to "woo-e2e" #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongruige
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Nice work on this @Luc45! This refactor helps to provide us separation of concerns for the different test types and sets us up for the next stages in QIT. Self tests all passed:
| @@ -306,6 +306,24 @@ public function execute( InputInterface $input, OutputInterface $output ) { | |||
|
|
|||
| $command->add_option_to_send( 'zip' ); | |||
|
|
|||
| if ( $test_type === 'api' ) { | |||
There was a problem hiding this comment.
I like this so we can always come back and add custom API tests in the future.
| // This will be hidden while custom test type is in development, but kept as an alias to "woo-e2e". | ||
| if ( $test_type === 'e2e' ) { | ||
| try { | ||
| $hide_e2e = $this->environment->get_cache()->get_manager_sync_data( 'hide_e2e' ); |
There was a problem hiding this comment.
I like how this configuration is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On current versions of QIT CLI, they will see both the renamed and the alias:
Once they update to the latest version, they will see just the renamed:
The aliases are still there, but they are hidden. If they run it (as in a CI script that still uses
e2eas the test-type), it still works:If the user starts a test using
e2eas the test type, instead ofwoo-e2e, internally we route it to the renamed test type and log it to keep track of usage:In the future, when
e2eactually refers to custom tests, we will:1.1 If yes, we just run it
1.2 If no, this can be either because the dev hasn't added custom tests yet, or because it's a old CI script still pointing to this test type
getenv('CI')is true, we just run thewoo-e2etest type and add a warning to the testTesting Instructions
Testing instructions will be added to the Manager PR.