Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --source option #196

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Fix --source option #196

merged 3 commits into from
Aug 22, 2024

Conversation

Luc45
Copy link
Member

@Luc45 Luc45 commented Aug 22, 2024

This PR fixes the --source option on run:e2e as discussed in Slack.

@Luc45 Luc45 requested a review from MrJnrman August 22, 2024 15:19
@Luc45 Luc45 self-assigned this Aug 22, 2024
@MrJnrman
Copy link
Contributor

Thanks for working on this @Luc45. It works great with absolute paths, but not with relative paths. Maybe we can pass the source through realpath when setting up the volumes here

qit-cli/src/src/Environment/ExtensionDownload/ExtensionDownloader.php

Line 92 in 9d76f30

// Add a volume bind.

MrJnrman
MrJnrman approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@MrJnrman MrJnrman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great with themes and plugins. Thanks Lucas! 🚢

@MrJnrman MrJnrman merged commit d5ca271 into trunk Aug 22, 2024
1 check passed
@MrJnrman MrJnrman deleted the 24-08/fix-source-option branch August 22, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrJnrman MrJnrman MrJnrman approved these changes

Assignees

@Luc45 Luc45

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Luc45 @MrJnrman