Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add self-tests for the Validation test #198

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

Luc45
Copy link
Member

@Luc45 Luc45 commented Aug 28, 2024

This PR adds self-tests for the Validation test.

We added 4 scenarios:

  • Main plugin
  • Missing plugin
  • Main theme
  • Missing theme

Then we generated the snapshots of the results to make sure they are as expected.

Testing Instructions

  • Just review the snapshots and make sure they are as expected
  • The ones with "Main" should be a success and the PHP header should be correctly identified
  • The ones with "Missing" should be a warning, and the PHP header should be false

Examples:

image

image

@Luc45 Luc45 requested a review from singerb August 28, 2024 12:51
@Luc45 Luc45 self-assigned this Aug 28, 2024
Copy link
Contributor

@singerb singerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snapshots look correct, tests run correctly.

@Luc45
Copy link
Member Author

Luc45 commented Aug 28, 2024

Sounds good, I'll be merging this when the upstream PR has been merged.

@Luc45 Luc45 merged commit 178822d into trunk Aug 29, 2024
@Luc45 Luc45 deleted the 24-08/validation-self-test branch August 29, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants