Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SemGrep and exclusion tests #26

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Conversation

Luc45
Copy link
Member

@Luc45 Luc45 commented Apr 24, 2023

This PR:

  • Updates the QIT Self Tests to account for SemGrep.
  • Adds a self-test for Security tests that assert that:
    • Exclude patterns can be set globally to be ignored by PHPCS
    • Exclude patterns can be set per-rule on PHPCS (Eg: MailPoet could exclude EscapeOutput rule on generated/twig directory).

@Luc45 Luc45 requested a review from zhongruige April 24, 2023 22:12
@Luc45 Luc45 self-assigned this Apr 24, 2023
@Luc45 Luc45 requested a review from MrJnrman April 24, 2023 22:12
Copy link
Contributor

@zhongruige zhongruige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for getting this in @Luc45! A quick follow up we'll want to try and do is add some documentation to the public docs around the changes added here, but it doesn't need to hold up this PR.

@Luc45 Luc45 merged commit 7e0786b into trunk Apr 27, 2023
@Luc45 Luc45 deleted the 23-04/updated-security-self-tests branch April 27, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants