Allow to use extension slugs in the "--additional_woo_plugins" parameter #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongruige
reviewed
Feb 21, 2023
| @@ -148,6 +148,19 @@ public function execute( InputInterface $input, OutputInterface $output ) { | |||
| $options['event'] = 'cli_published_extension_test'; | |||
| } | |||
|
|
|||
| // Convert "Additional Woo Plugins" Slugs to IDs. | |||
| if ( ! empty( $options['additional_woo_plugins'] ) ) { | |||
There was a problem hiding this comment.
This made me think for a future iteration that an interesting extension on this could be to add an "additional_plugins" that allows fetching the plugin by slug and installs it, for any plugins available. For example if we wanted to add in hello-dolly, something like --additional_plugins=hello-dolly,some-plugin (though we'd need some handling around if the plugin doesn't exist, such as if someone accidentally mistypes the name, for example).
zhongruige
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Thanks for getting this in @Luc45! This is awesome have as an option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the behavior of
--additional_woo_pluginsconsistent by also accepting a comma-separated list of slugs. Previously, it would only accept IDs.How to test this:
You can also test this by running a command such as this:
./qit run:e2e automatewoo --additional_woo_plugins=woocommerce-product-addons,woocommerce-min-max-quantities