Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate banner #3562

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

Mayisha
Copy link
Contributor

@Mayisha Mayisha commented Oct 30, 2024

Fixes #3561

When the legacy checkout is enabled, 2 different banners are displayed with a similar message.

Changes proposed in this Pull Request:

Showing 'LegacyExperienceTransitionNotice' only when the promotional banner is not about the same.

Testing instructions

  • When the promotional surface is about re-auth, the yellow banner about enabling the new checkout experience should be displayed.
Screenshot 2024-10-30 at 6 01 05 PM
  • When the promotional surface is about the new checkout experience, the yellow banner about enabling the new checkout experience should not be there.
Screenshot 2024-10-30 at 6 00 39 PM

@aheckler
Copy link
Contributor

Does this affect only the Payment Methods tab, or both Payment Methods and Settings tabs?

@Mayisha
Copy link
Contributor Author

Mayisha commented Oct 31, 2024

Does this affect only the Payment Methods tab, or both Payment Methods and Settings tabs?

@aheckler only the payment methods tab.

@Mayisha Mayisha requested review from a team and wjrosa and removed request for a team October 31, 2024 06:19
@wjrosa
Copy link
Contributor

wjrosa commented Oct 31, 2024

Thanks for this fix, @Mayisha ! I am getting the following error when I enable the legacy checkout:
Screenshot 2024-10-31 at 09 02 53
It seems the error happens with promotional-banner-section.js

@Mayisha
Copy link
Contributor Author

Mayisha commented Nov 5, 2024

Hi @wjrosa 👋

I am getting the following error when I enable the legacy checkout:

I can not reproduce this issue. However, I was getting some other console errors/warnings which I fixed in e5a72d0. 👀

@Mayisha Mayisha requested a review from wjrosa November 5, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicate banner
3 participants