Fix formatting product when variation has no attributes #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog: fix
jorgemd24
reviewed
Mar 7, 2024
| @@ -230,7 +230,7 @@ public function get_formatted_product( WC_Product $product, $variation = false ) | |||
| $variation = $product->get_attributes(); | |||
| } | |||
|
|
|||
| if ( false !== $variation ) { | |||
| if ( false !== $variation && is_array( $variation ) ) { | |||
There was a problem hiding this comment.
I think just having if ( is_array( $variation ) ) would be sufficient, so we can remove the false !== $variation
There was a problem hiding this comment.
I removed the variation function param completely.
There was a problem hiding this comment.
Brought back the $variation, so we'd use it for non-"variation" producs
tomalec
force-pushed
the
fix/371-variable-product
branch
from
e1428eb
to
ec9848a
Compare
add a bit more elaborate code comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
quick-fix formatting product when variation has no attributes
Address #371
I was not able to reproduce it using UI, but according to #371 there is a chance to get
woocommerce_add_to_cartfired for a product with$variationother thanfalsebut with no attributes.Checks:
Screenshots:
Detailed test instructions:
$variation = []towoocommerce-google-analytics-integration/includes/class-wc-abstract-google-analytics-js.php
Line 232 in 7594c1b
Additional details:
Changelog entry