Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E tests for denying via WP Consent API #430

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

tomalec
Copy link
Member

@tomalec tomalec commented Jun 3, 2024

Changes proposed in this Pull Request:

This is a small add-on to #429.
So, we test that a visitor can also deny their consent using the WP Consent API.

Checks:

  • Does your code follow the WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Screenshots:

image

Detailed test instructions:

  1. Checkout add/wp-consent-api-integration-tests-2 and build extension
  2. Setup E2E environment and run tests
  3. Confirm all tests pass

@tomalec tomalec requested a review from a team June 3, 2024 19:46
@tomalec tomalec self-assigned this Jun 3, 2024
@github-actions github-actions bot added type: enhancement The issue is a request for an enhancement. changelog: add A new feature, function, or functionality was added. labels Jun 3, 2024
Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding more test cases. I can run all E2E tests successfully. LGTM.

The only comment is not a blocker

tests/e2e/specs/js-scripts/wp-consent-api.test.js Outdated Show resolved Hide resolved
@tomalec tomalec merged commit fafed67 into trunk Jun 4, 2024
1 check passed
@tomalec tomalec deleted the add/wp-consent-api-integration-tests-2 branch June 4, 2024 21:46
@martynmjones martynmjones mentioned this pull request Jun 5, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: add A new feature, function, or functionality was added. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants