-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retire phpcs-diff
#446
Retire phpcs-diff
#446
Conversation
tests/class-unittestsbootstrap.php
Outdated
@@ -69,8 +70,10 @@ public function set_path_props() { | |||
* Set server props | |||
*/ | |||
public function set_server_props() { | |||
// phpcs:disable WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.ValidatedSanitizedInput.InputNotSanitized |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we can sanitize the input here instead of ignoring the line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this file is used for PHPUnit testing, I thought it would be okay to skip the checks.
I revisited its logic once and found that after the rewrite it didn't have to skip checking. Adjusted in db107f7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eason9487 for opening this PR
I tested it and works
I left one comment regarding the handle of the PHPCS exceptions instead of ignoring them if possible, in this PR or maybe create an Issue for it.
Approved tho since it's not a blocker because it was not introduced in this PR.
…ip phpcs checks. Address: #446 (comment)
Changes proposed in this Pull Request:
This PR retires
phpcs-diff
and add thephpcs
workflow.Checks:
Detailed test instructions:
npm run lint:php
to see if the check can passphpcs
workflowphpcs
workflowChangelog entry