Combine iOS and macOS plugins #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some UI elements e.g. `RaisedButton` were renamed. The macOS deployment target needs to be 10.14 for recent versions of flutter's `FlutterMacOS` pod. The Xcode project was automatically upgraded by xcode-build, and Flutter build also makes some automatic changes to generated files even for linux and windows platforms.
Flutter >= 3.7.0 supports sharing source code between iOS and macOS plugins. The iOS code in `quick_blue` was removed and replaced with just the macOS federated plugin, which was modified to support both iOS and macOS.
The API has been modified to add a new `forServices:` named parameter to the `QuickBlue.scan(..)` method. Pass in a list of primary service UUIDs to only scan for devices advertising one of thoese services. Without this, there was no way to identify a device specific to your app. NOTE: The new parameter is only effective on Apple platforms. On Linux it is currently ignored and on Android and Windows it will probably crash as I've not modified the platform channel code at all.
Dependency versions also bumped (except Windows which was not touched).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is 99% the same, and since Flutter 3.7.0, it can be shared.