Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactivate agents and prevent draining recently active agents #163

Merged
merged 7 commits into from
Jul 7, 2024
Merged

Reactivate agents and prevent draining recently active agents #163

merged 7 commits into from
Jul 7, 2024

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Jul 2, 2024 •
edited
Loading

closes #157

  • reactivate no-schedule agents before creating new ones
  • prevent agents from being drained if they have recently done any tasks
  • migrate from goblin to t.Run as it has a nicer options allowing to easily run just a t.Run block from a test

@anbraten anbraten added the feature Add new feature label Jul 2, 2024
@anbraten anbraten requested a review from a team July 2, 2024 16:49
@anbraten anbraten changed the title reactivate agents before creating new ones Reactivate agents before creating new ones and prevent draining agents that recently have recently worked Jul 7, 2024
@anbraten anbraten changed the title Reactivate agents before creating new ones and prevent draining agents that recently have recently worked Reactivate agents and prevent draining recently active agents Jul 7, 2024
xoxys
xoxys previously approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@xoxys xoxys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but untested. Thanks for adding tests.

@anbraten anbraten requested a review from xoxys July 7, 2024 09:47
@anbraten anbraten merged commit 961d729 into main Jul 7, 2024
3 checks passed
@anbraten anbraten deleted the reactivate-agents branch July 7, 2024 09:49
@woodpecker-bot woodpecker-bot mentioned this pull request Jul 7, 2024
Merged
1 task
@woodpecker-bot
Copy link
Contributor

🎉 This PR is included in version 0.3.0 🎉

The release is now available here

Thank you for your contribution. ❤️📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoxys xoxys xoxys approved these changes

Assignees
No one assigned
Labels
feature Add new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re"activate" agents when more work has to be done
3 participants
@anbraten @woodpecker-bot @xoxys