Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: agent panic when node is terminated during step execution #3331

Merged
merged 5 commits into from
Feb 5, 2024
Merged

fix: agent panic when node is terminated during step execution #3331

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a600527
fix: handle wait step container statuses errors
fernandrone Jan 30, 2024
187ed9c
Merge branch 'handle-container-status-err' into fix-agent-panic
fernandrone Feb 5, 2024
4382b25
fix error messages: start w/ lowercase
fernandrone Feb 5, 2024
0c6de1c
log container state
fernandrone Feb 5, 2024
4eb4803
fix imports
fernandrone Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions pipeline/backend/kubernetes/kubernetes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,11 +263,23 @@ func (e *kube) WaitStep(ctx context.Context, step *types.Step, taskUUID string)
}

if isImagePullBackOffState(pod) {
return nil, fmt.Errorf("could not pull image for pod %s", pod.Name)
return nil, fmt.Errorf("could not pull image for pod %s", podName)
}

if len(pod.Status.ContainerStatuses) == 0 {
return nil, fmt.Errorf("no container statuses found for pod %s", podName)
}

cs := pod.Status.ContainerStatuses[0]

if cs.State.Terminated == nil {
err := fmt.Errorf("no terminated state found for container %s/%s", podName, cs.Name)
log.Error().Str("taskUUID", taskUUID).Str("pod", podName).Str("container", cs.Name).Interface("state", cs.State).Msg(err.Error())
6543 marked this conversation as resolved.
Show resolved Hide resolved
return nil, err
}

bs := &types.State{
ExitCode: int(pod.Status.ContainerStatuses[0].State.Terminated.ExitCode),
ExitCode: int(cs.State.Terminated.ExitCode),
Exited: true,
OOMKilled: false,
}
Expand Down