Allow to configure config extensions for repos #3349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwerty287
reviewed
Jun 6, 2024
server/model/repo.go
Outdated
Comment on lines
53
to
54
| SecretExtensionEndpoint string `json:"secret_extension_endpoint" xorm:"varchar(500) 'secret_extension_endpoint'"` | ||
| ConfigExtensionEndpoint string `json:"config_extension_endpoint" xorm:"varchar(500) 'config_extension_endpoint'"` |
There was a problem hiding this comment.
These are sent to all requests, including unauthorized.
Since you should use signing anyways that should be fine, but I just want to make sure this is expected?
| } | ||
|
|
||
| var blockedError error | ||
| if blockList.MatchHostOrIP(host, tcpAddr.IP) { |
There was a problem hiding this comment.
Is the blocklist used somewhere?
web/src/assets/locales/en.json
Outdated
Comment on lines
466
to
474
| "extensions": "Extensions", | ||
| "extensions_description": "Extensions are HTTP services that can be called by Woodpecker instead of using the builtin ones.", | ||
| "secrets_extension_endpoint": "Secrets extension endpoint", | ||
| "secrets_extension_alpha_state": "The secret extension is in alpha state and might change in the future.", | ||
| "extension_endpoint_placeholder": "e.g. https://my-extension-endpint.tld/api", | ||
| "config_extension_endpoint": "Config extension endpoint", | ||
| "extensions_signatures_public_key": "Public key for signatures", | ||
| "extensions_signatures_public_key_description": "This public key should be used by your extensions to verify webhook calls from Woodpecker.", | ||
| "extensions_configuration_saved": "Extensions configuration saved" |
There was a problem hiding this comment.
Can you put them into their own object?
anbraten
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #783
Allow users to set / use service extensions (config) on a per repo basis. Those extensions are little external webservice which can implement a set of endpoints to replace woodpeckers internal functionality like:
TODO